Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/frontend mbr gbr foolproof mechanism #123

Merged

Conversation

Alonza0314
Copy link
Contributor

Add friendly alert for MBR should be greater than GBR(both subscription and profile).

MBRGBRgreateralert

Copy link
Collaborator

@andy89923 andy89923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Alonza0314 ,

I am unfamiliar with the zod package, but I think there is a way to add the validation in the type schema instead of creating another validation code.

Maybe you can try zod refine in Google search(? ( I'm not sure XD)

frontend/src/pages/ProfileCreate/index.tsx Outdated Show resolved Hide resolved
@Alonza0314
Copy link
Contributor Author

Hi @Alonza0314 ,

I am unfamiliar with the zod package, but I think there is a way to add the validation in the type schema instead of creating another validation code.

Maybe you can try zod refine in Google search(? ( I'm not sure XD)

I've checked the DTO schema which all of them are written via zod. I think we can feat this function first and make the validation in another PR for the whole DTO schemas(profile and subscriber) if needed(?

@Alonza0314 Alonza0314 requested a review from andy89923 December 11, 2024 15:52
@Alonza0314
Copy link
Contributor Author

Hi @Alonza0314 ,

I am unfamiliar with the zod package, but I think there is a way to add the validation in the type schema instead of creating another validation code.

Maybe you can try zod refine in Google search(? ( I'm not sure XD)

Hi, @andy89923,
I discussed this with Ian yesterday. For now, we can proceed like this and add the valid part later in the backend.

@Alonza0314 Alonza0314 requested a review from andy89923 December 18, 2024 02:13
Copy link
Collaborator

@andy89923 andy89923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ianchen0119 ianchen0119 merged commit 46c2937 into free5gc:main Dec 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants